Reverse direction of hin/hinjac in wrapper functions and update various examples. #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…). 2) Keep old behavior as default through new parameter. 3) Update documentation, including examples, and unit tests.
…8). 2) Keep old behavior as default through new parameter. 3) Update documentation, including examples, and unit tests. 4) Correct Powell example to match that in Rsolnp
…old behavior as default with new parameter 3) Clean up HS100 example; analytic gradient works now - as it should. 3) Update documentation and unit tests
…nequalities to <= 2) Maintain old behavior as default with new parameter 3) Clean up HS100 example 4) Update documentation and unit tests
…on of inequalities to <= 2) Maintain old behavior as default with new parameter 3) Clean up Hartmann 6 example 4) Update documentation and unit tests.
…S100 example so it is now accurate with analytic gradient 3) Updated documentation and unit tests.
…and DESCRIPTION. Release version is minor, since deprecating the direction is a significant change. It is not major, since the API remains the same, currently.
… line with others.
|
As this wasn't merged yet, I upgraded all the deprecated messages to warnings and brought the SLSQP test suite in line with the remainders, in that the new behavior is tested first and the old at the end. This way, when we finally remove the old behavior it will be simpler to prune the test suite. |
|
Awesome! that answers my various comments in the issues! Thanks again @aadler ! |
This was referenced Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should address issues #148, #152, and #156. It reverses the expected inequality direction of hin/hinjac without changing the default behavior by adding a
deprecatedBehaviorparameter, whose default isTRUE. The idea being a future (major/breaking) release will change the default behavior toFALSEand a subsequent release will remove the option completly. It also cleans up many, but not all, of examples. It combines all the changes since the last push to CRAN (2.0.3) nto one release (2.1.0) in NEWS.md, which has both a synopsis of the major change and collected bullet points.